Alon Bar-Lev has posted comments on this change. Change subject: userportal, webadmin: branding support[WIP]. ......................................................................
Patch Set 4: First of all, great work! it is huge improvement of current offering. Summary of offline discussion: Important not to effect ordering using file content, as packager and/or system administrator would like to reorder the branding using different sequence. As discussed in the past and summarized at bug#890568, ordering should be done using directory name in conf.d *NIX convention. I recommend to detach configuration from implementation assumption, for example not assume you have single common css and per application css. Either remove the common and use css include or for each application support a list of css. I will assist in packaging of the branding packages. Thank you! -- To view, visit http://gerrit.ovirt.org/13181 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a8a426ce7d688d33c5ae2b70632c836843106b2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
