Alon Bar-Lev has posted comments on this change. Change subject: userportal, webadmin: branding support[WIP]. ......................................................................
Patch Set 5: (1 inline comment) Hi, Can you please add README.branding with the structure of the branding files? This will enable people to understand what needs to be done. Similar to[1]. Can you please send me/paste URL here of branding package example? Thanks! [1] https://github.com/alonbl/ovirt-engine/blob/otopi/README.developer .................................................... File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/branding/BrandingManager.java Line 91: } Line 92: } Line 93: // Reverse so the lowest order is at the top. This because the css gets included in reverse order Line 94: // in the host page. Line 95: Collections.reverse(themes); Not sure I understand the comment... Either we collect 01, 02, 03 while 03 overrides 02 which in turn overrides 01 Or we collect 01, 02, 03 while 01 shadows 02 which in turn shadows 03 I prefer the first approach... But anyway, I don't understand why you need to reverse... Line 96: } Line 97: return themes; Line 98: } Line 99: -- To view, visit http://gerrit.ovirt.org/13181 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a8a426ce7d688d33c5ae2b70632c836843106b2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
