Vojtech Szocs has posted comments on this change. Change subject: webadmin: Select english when browser is other locale ......................................................................
Patch Set 5: I think we should improve this patch. According to [1,2] client-side locale detection via "navigator.language" works with the language used for the browser application itself (menus, messages, etc), i.e. the language for which browser was compiled possibly matching overall OS language setting, and DOES NOT reflect content language preference, e.g. in Firefox "Edit / Preferences / Content / Languages". Alex, I'm really curious how the patch worked for you, IIUC content language preference has no effect on locale detection. In AbstractLoginPopupView.initLocalizationEditor(), is "currentLocale" really "fr" when you set French as preferred content language? (it doesn't work for me, I compiled for "en,fr,ja") The proper solution, as suggested in [1,2] is to do preferred content language detection on server via HTTP 'Accept-Language' header, and if not present, just fall back to default GWT client-side locale detection mechanism. I'll submit new patch set to fix the issue mentioned above. [1] http://manolocarrasco.blogspot.cz/2009/11/gwt-client-side-vs-server-side-locale.html [2] http://stackoverflow.com/questions/1043339/javascript-for-detecting-browser-language-preference -- To view, visit http://gerrit.ovirt.org/11047 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1b31fe65c306602c45c85857ccc7392e16dc8d3 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
