Ofer Schreiber has posted comments on this change. Change subject: packaging: less intrusive method for httpd integration ......................................................................
Patch Set 6: (2 inline comments) Some minor comments. Great work. .................................................... File backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml Line 206: <url-pattern>/OvirtEngineWeb/ValidateSession</url-pattern> Line 207: </servlet-mapping> Line 208: Line 209: <welcome-file-list> Line 210: <welcome-file>ovirt-engine.html</welcome-file> tab and spaces? Line 211: </welcome-file-list> Line 212: Line 213: <!-- Go to the index when a page is not found (preserving the Line 214: 404 status code): --> .................................................... File packaging/fedora/setup/output_messages.py Line 117: Alternatively you can use JBoss directly (on ports higher than 1024)\n\ Line 118: Do you wish to override current httpd configuration and restart the service?" % basedefs.APP_NAME Line 119: Line 120: INFO_CONF_PARAMS_OVERRIDE_HTTPD_ROOT_USAGE = "Configure the apache root redirection" Line 121: INFO_CONF_PARAMS_OVERRIDE_HTTPD_ROOT_PROMPT = "oVirt Engine is being set up at /ovirt-engine URL path. \ I don't see any reason for using the "oVirt Engine is..." here, this should be re-phrased for something more human readable. Line 122: Should the setup configure apache root path redirection, so engine could be also available at /?\ Line 123: This will override any other site in the server." Line 124: INFO_CONF_PARAMS_HTTP_PORT_USAGE="Configures HTTP service port" Line 125: INFO_CONF_PARAMS_HTTP_PORT_PROMPT="HTTP Port" -- To view, visit http://gerrit.ovirt.org/13318 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89a47a99e28de0905183dc502cb0b35c80f77e6d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
