Juan Hernandez has posted comments on this change. Change subject: packaging: less intrusive method for httpd integration ......................................................................
Patch Set 4: (2 inline comments) .................................................... File packaging/fedora/setup/ovirt-engine-proxy.conf.in Line 6: Redirect /ovirt-engine /ovirt-engine/ Line 7: ProxyPass /ovirt-engine/ ajp://localhost:@JBOSS_AJP_PORT@/ Line 8: Line 9: <LocationMatch ^/(UserPortal|OvirtEngineWeb|webadmin|ca.crt|engine.ssh.key.txt|rhevm.ssh.key.txt|docs|spice|ovirt-engine.html|404.html)> Line 10: ProxyPass ajp://localhost:@JBOSS_AJP_PORT@/$1 I think that LocationMatch has to be combiled with ProxyPassMatch, and if you use $1 then the regular expression should match the complete URL, not just the beginning. Line 11: </LocationMatch> Line 12: Line 13: <Proxy ajp://localhost:@JBOSS_AJP_PORT@> Line 14: # This is needed to make sure that connections to the application server Line 19: # This is needed to make sure that long RESTAPI requests have time to Line 20: # finish before the web server aborts the request as the default timeout Line 21: # (controlled by the Timeout directive in httpd.conf is 60 seconds). Line 22: ProxySet timeout=3600 Line 23: </Proxy> This ^ should go before it is used, so at the beginning of the file. Line 24: # Line 25: # Remove the Expect headers from API requests (this is needed to fix a Line 26: # problem with some API clients): Line 27: # -- To view, visit http://gerrit.ovirt.org/13318 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89a47a99e28de0905183dc502cb0b35c80f77e6d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
