Alex Lourie has posted comments on this change.
Change subject: packaging: less intrusive method for httpd integration
......................................................................
Patch Set 6: (2 inline comments)
....................................................
File packaging/fedora/setup/engine-setup.py
Line 244: "USE_DEFAULT" : True,
Line 245: "NEED_CONFIRM" : False,
Line 246: "CONDITION" : False},
Line 247:
Line 248: { "CMD_OPTION" :"override-httpd-root",
I see it when I run setup.
Why not let users decide about redirection? We default to 'yes', which will
result in the same state we have now...
Line 249: "USAGE"
:output_messages.INFO_CONF_PARAMS_OVERRIDE_HTTPD_ROOT_USAGE,
Line 250: "PROMPT"
:output_messages.INFO_CONF_PARAMS_OVERRIDE_HTTPD_ROOT_PROMPT,
Line 251: "OPTION_LIST" :["yes","no"],
Line 252: "VALIDATION_FUNC" :validate.validateOptions,
Line 766: )
Line 767:
Line 768:
Line 769: # if redirection of root required, copy a file into the conf.d
folder.
Line 770: if controller.CONF["OVERRIDE_HTTPD_ROOT"] == "yes":
strange, in my test it doesn't...
Line 771: utils.copyFile(
Line 772: basedefs.FILE_OVIRT_HTTPD_CONF_ROOT_TEMPLATE,
Line 773: basedefs.FILE_OVIRT_HTTPD_CONF_ROOT,
Line 774: )
--
To view, visit http://gerrit.ovirt.org/13318
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89a47a99e28de0905183dc502cb0b35c80f77e6d
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
