Sahina Bose has posted comments on this change.

Change subject: gluster: Use brick server for advanced details
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeAdvancedDetailsQuery.java
Line 121: 
Line 122:         // brick server is down
Line 123:         return super.getUpServerId(clusterId);
Line 124:     }
Line 125: 
Ok. Hadn't noticed that.
Line 126:     private GlusterVolumeAdvancedDetails fetchAdvancedDetails(String 
volumeName) {
Line 127:         VDSReturnValue returnValue =
Line 128:                 
runVdsCommand(VDSCommandType.GetGlusterVolumeAdvancedDetails,
Line 129:                         new 
GlusterVolumeAdvancedDetailsVDSParameters(getUpServerId(),


--
To view, visit http://gerrit.ovirt.org/12979
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id4acb0bbe84bacab714926d69b639bbda970df9a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to