Gilad Chaplik has posted comments on this change.
Change subject: gluster: Use brick server for advanced details
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeAdvancedDetailsQuery.java
Line 110: * Otherwise returns a random up server from the cluster
Line 111: */
Line 112: protected Guid getUpServerId() {
Line 113: if (brick == null) {
Line 114: return super.getUpServerId(clusterId);
does super ref needed here?
Line 115: }
Line 116:
Line 117: VDS brickServer = getVdsDao().get(brick.getServerId());
Line 118: if (brickServer.getStatus() == VDSStatus.Up) {
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterQueriesCommandBase.java
Line 22: super(parameters);
Line 23: }
Line 24:
Line 25: protected VdsDAO getVdsDao() {
Line 26: return DbFacade.getInstance().getVdsDao();
maybe move it to QueriesCommandBase? the other queries (!gluster) use it as
well (a future re-factoring is needed :))
Line 27: }
Line 28:
Line 29: protected GlusterVolumeDao getGlusterVolumeDao() {
Line 30: return DbFacade.getInstance()
--
To view, visit http://gerrit.ovirt.org/12979
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4acb0bbe84bacab714926d69b639bbda970df9a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
