Allon Mureinik has posted comments on this change.

Change subject: core: add ability edit NFS path in webadmin
......................................................................


Patch Set 7: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java
Line 96:     @Override
Line 97:     protected Map<String, Pair<String, String>> getExclusiveLocks() {
Line 98:         //lock the path to NFS to avoid at the same time if some other 
user tries to:
Line 99:         // add new storage domain to same path or edit another storage 
server connection to point to same path
Line 100:         return 
Collections.singletonMap(getParameters().getStorageServerConnection().getconnection(),
 LockMessagesMatchUtil.STORAGE_CONNECTION);
StorageServerConnection is a superset of NFS and iSCSI connection parameters - 
there, we don't use connection, we use iqn+port (+authentication details)
Line 101:     }


--
To view, visit http://gerrit.ovirt.org/12372
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifaff5344ff191d6bdf53cc706c7bb796167a56b3
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to