Alissa Bonas has posted comments on this change.
Change subject: core: add ability edit NFS path in webadmin
......................................................................
Patch Set 4: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java
Line 29: import org.ovirt.engine.core.utils.transaction.TransactionSupport;
Line 30:
Line 31: @NonTransactiveCommandAttribute
Line 32: public class UpdateStorageServerConnectionCommand<T extends
StorageServerConnectionParametersBase> extends
StorageServerConnectionCommandBase<T> {
Line 33: StorageServerConnections oldConnection = null;
Done
Line 34:
Line 35: public UpdateStorageServerConnectionCommand(T parameters) {
Line 36: super(parameters);
Line 37: }
Line 44: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_CONNECTION_UNSUPPORTED_ACTION_FOR_STORAGE);
Line 45: }
Line 46:
Line 47: // Check if the NFS path has a valid format
Line 48: if (newConnectionDetails.getstorage_type() == StorageType.NFS
Done
Line 49: && !new
NfsMountPointConstraint().isValid(newConnectionDetails.getconnection(), null)) {
Line 50: return
failCanDoAction(VdcBllMessages.VALIDATION_STORAGE_CONNECTION_INVALID);
Line 51: }
Line 52:
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommandTest.java
Line 75: oldConnection.setid(id.toString());
Line 76:
oldConnection.setconnection("multipass.my.domain.tlv.company.com:/export/allstorage/data1");
Line 77: oldConnection.setNfsTimeo((short)50);
Line 78: oldConnection.setstorage_type(StorageType.NFS);
Line 79: oldConnection.setNfsVersion(NfsVersion.V4);
Done
Line 80:
Line 81:
when(storageConnDao.get(newConnection.getid())).thenReturn(oldConnection);
Line 82:
Line 83: }
--
To view, visit http://gerrit.ovirt.org/12372
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifaff5344ff191d6bdf53cc706c7bb796167a56b3
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
