Alon Bar-Lev has posted comments on this change. Change subject: core: introduce osinfo service implementation over RMI ......................................................................
Patch Set 3: > exactly 14 lines of code, the rest are imports and javadoc comments :) when a > new library is out we don't have to do nothing. the API is stable OK, so I probably count non generated code... > If you claim that its fast and easy to publish a src jar for libosinfo to > Maven Central then it maybe worth the effort. I think that the best is to generate all code directly from sources during build. A simple get of the upstream tarball, extract the header and run the generator, this way we have no manual modification of sources and we can upgrade easily to new libraries, and we do not check in generated code into our repository... this is what I would have done anyway. -- To view, visit http://gerrit.ovirt.org/12937 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia893bdc3dfc486e0b3e735f4e187996710a05f54 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
