Juan Hernandez has posted comments on this change. Change subject: core: introduce osinfo service implementation over RMI ......................................................................
Patch Set 2: (2 inline comments) .................................................... File backend/manager/tools/src/main/modules/org/ovirt/engine/core/tools/main/module.xml Line 15: <module name="org.apache.log4j"/> Line 16: <module name="org.ovirt.engine.core.common"/> Line 17: <module name="org.ovirt.engine.core.compat"/> Line 18: <module name="org.ovirt.engine.core.dependencies"/> Line 19: <module name="org.ovirt.engine.core.utils" export="true"/> As far as I understand the "export" modifier only has an effect for other modules that use this module, and there isn't such module. Access to the utils module is granted simply by listing it, without the "export". What is the error that you see if you remove this "export"? Line 20: <module name="org.postgresql"/> Line 21: <module name="sun.jdk"/> Line 22: <module name="com.sun.jna"/> Line 23: </dependencies> Line 18: <module name="org.ovirt.engine.core.dependencies"/> Line 19: <module name="org.ovirt.engine.core.utils" export="true"/> Line 20: <module name="org.postgresql"/> Line 21: <module name="sun.jdk"/> Line 22: <module name="com.sun.jna"/> It is ok to have this in the "dependencies" module, but in fact it is smarter if you have a module specifically for JNA, although it takes extra work and may not be worth. I created the "dependencies" module as a way to avoid having specific modules for commons-compress, mina-core, sshd-core, quartz, spring, xmlrpc, etc. Going forward I would like to split that into several different modules, each with its own module.xml file and their set of dependencies. So if you do that for JNA now I would appreciate, although it is not required. Line 23: </dependencies> Line 24: -- To view, visit http://gerrit.ovirt.org/12937 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia893bdc3dfc486e0b3e735f4e187996710a05f54 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
