Roy Golan has posted comments on this change.
Change subject: core: introduce osinfo service implementation over RMI
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/tools/src/main/modules/org/ovirt/engine/core/tools/main/module.xml
Line 15: <module name="org.apache.log4j"/>
Line 16: <module name="org.ovirt.engine.core.common"/>
Line 17: <module name="org.ovirt.engine.core.compat"/>
Line 18: <module name="org.ovirt.engine.core.dependencies"/>
Line 19: <module name="org.ovirt.engine.core.utils" export="true"/>
this module is the module I'm loading and my class(LibosinfoServer) needs
access to utils classes. without the export my Main class loader won't see it.
just to explain, the script that loads the daemon is doing
java" -Djava.rmi.server.hostname=localhost -jar
"${JBOSS_HOME}/jboss-odules.jar" \
-dependencies org.ovirt.engine.core.tools \
-class org.ovirt.engine.core.osinfo.server.LibosinfoServer
Am I missing something?
Line 20: <module name="org.postgresql"/>
Line 21: <module name="sun.jdk"/>
Line 22: <module name="com.sun.jna"/>
Line 23: </dependencies>
Line 18: <module name="org.ovirt.engine.core.dependencies"/>
Line 19: <module name="org.ovirt.engine.core.utils" export="true"/>
Line 20: <module name="org.postgresql"/>
Line 21: <module name="sun.jdk"/>
Line 22: <module name="com.sun.jna"/>
dropped this and added jna.jar as a module to dependencies.
Line 23: </dependencies>
Line 24:
--
To view, visit http://gerrit.ovirt.org/12937
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia893bdc3dfc486e0b3e735f4e187996710a05f54
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
