Gilad Chaplik has posted comments on this change.
Change subject: webadmin,userportal: Show data centers and their clusters based
on configured cluster service
......................................................................
Patch Set 7: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetStoragePoolsByClusterServiceQuery.java
Line 1: /**
Line 2: *
not addressed
Line 3: */
Line 4: package org.ovirt.engine.core.bll.storage;
Line 5:
Line 6: import org.ovirt.engine.core.bll.QueriesCommandBase;
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalNewVmModelBehavior.java
Line 39: @Override
Line 40: public void Initialize(SystemTreeItemModel systemTreeSelectedItem)
Line 41: {
Line 42: // The custom properties tab should be hidden on the User
Portal
Line 43: getModel().setIsCustomPropertiesTabAvailable(false);
why we need it, isn't it get covered in:
http://gerrit.ovirt.org/#/c/12171/2
Line 44:
Line 45: // Get datacenters with permitted create action
Line 46:
AsyncDataProvider.GetDataCentersWithPermittedActionOnClusters(new
AsyncQuery(getModel(),
Line 47: new INewAsyncCallback() {
--
To view, visit http://gerrit.ovirt.org/11395
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb63c7e2addf525bb527d94694a8dfc752d69154
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Libor Spevak <lspe...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Libor Spevak <lspe...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
