Gilad Chaplik has posted comments on this change.
Change subject: webadmin,userportal: Show data centers and their clusters based
on configured cluster service
......................................................................
Patch Set 5: (3 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetStoragePoolsByClusterServiceParameters.java
Line 3: /**
Line 4: *
Line 5: *
Line 6: */
Line 7: public class GetStoragePoolsByClusterServiceParameters extends
VdcQueryParametersBase {
consider inheritance from previous file?
Line 8:
Line 9: private static final long serialVersionUID = -4118891133830586523L;
Line 10:
Line 11: boolean supportsVirtService;
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalExistingVmModelBehavior.java
Line 45: Object[] array = (Object[]) target;
Line 46: ExistingVmModelBehavior behavior =
(ExistingVmModelBehavior) array[0];
Line 47: UnitVmModel model = (UnitVmModel) array[1];
Line 48: ArrayList<VDSGroup> clusters =
(ArrayList<VDSGroup>) returnValue;
Line 49: InitClusters(clusters, model, true, false);
why you need to do filtering here?
Line 50: behavior.InitTemplate();
Line 51: behavior.InitCdImage();
Line 52:
Line 53: }
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalNewVmModelBehavior.java
Line 101: (ArrayList<VDSGroup>)
returnValueList.get(0).getReturnValue();
Line 102: ArrayList<VmTemplate> templates =
Line 103: (ArrayList<VmTemplate>)
returnValueList.get(1).getReturnValue();
Line 104:
Line 105: InitClusters(clusters, true, false);
same
Line 106: InitTemplates(templates);
Line 107: InitCdImage();
Line 108: }
Line 109:
--
To view, visit http://gerrit.ovirt.org/11395
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb63c7e2addf525bb527d94694a8dfc752d69154
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Libor Spevak <lspe...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Libor Spevak <lspe...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
