Michael Kublin has posted comments on this change. Change subject: engine: Removing opening of global transaction from endAction ......................................................................
Patch Set 1: Re:""not all scenarios will be broken." By definition, behaviour will change - if this is not broken, it should be explained why this is OK." - Meanwhile you did not provide what is broken. Re:" the example of LiveMoveDisks - agree, that should be fixed. The fact that it is broken is no reason to break other flows too. " - this is one example, you understand that there are a lot commands with such problem, waiting for patch. re:""all daos operation which are belongs to same flow should be under same transaction, but this should be done by code writer and not by framework." Agree. But this shouldn't be done /after/ the framework behaviour has changed, but together with it. No more, no less." - great send a patch. "Re: deprecated code - disagree. MoveVM/MoveTemplate still exist as REST operations, and other commands extend them and use their endXYZ methods. Sure, they should be killed off (hence, deprecated, as you mentioned), but this does not mean we can just break them without care. " - regards rest, you have a new bug, the behaviour from GUI and rest is different, please fix it. Deprecated command should be removed, fix it - and fix is not related to that patch. Meanwhile conclusion: 1. We have half of flows that are not working in the way that was expected a bug which should be fixed, not related to patch. 2. We have a deprecated flows and actually a bug that REST is based on deprecated flows, when GUI is not - Again bug which is not related to patch 3. We have a bug which is reproduced time after time - "Transaction was cancelled because of time out" which should be solved by patch, and patch should also provide performance improvements and code clean up 4. We have some flows that patch can influence, but if a bug described in 1 will be fixed, the following flows will be fixed also, so in some way event 4 is not related to patch -- To view, visit http://gerrit.ovirt.org/12010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4c114d4d3072b8b9213d73cf8e155d98c5fbef6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
