Frank Kobzik has posted comments on this change.
Change subject: frontend: Non-plugin automatic invocation of console session
......................................................................
Patch Set 4: (2 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java
Line 277:
Line 278: VerticalPanel innerPanel = new VerticalPanel();
Line 279: innerPanel.add(buildTextArea("filename",
"console.vv"));//$NON-NLS-1$ $NON-NLS-2$
Line 280: innerPanel.add(buildTextArea("contenttype",
"x-virt-viewer"));//$NON-NLS-1$ $NON-NLS-2$
Line 281: innerPanel.add(buildTextArea("content",
configFileContent));//$NON-NLS-1$
I know what you're getting at, but I would suggest sticking to this one. But I
think this is sufficient, and also adding more params could make the method
signature less readable. I there is any reason for parametrizing this in future
(like adding support for multiple console clients), it will be easy to
parametrize it.
Line 282:
Line 283: formPanel.setWidget(innerPanel);
Line 284: formPanel.setAction(CONSOLE_CONFIG_SERVLET_URL);
Line 285:
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VncConsoleModel.java
Line 93:
.append(lineSeparator).append("host=").append(hostName)//$NON-NLS-1$
Line 94:
.append(lineSeparator).append("password=").append(otp64)//$NON-NLS-1$
Line 95:
.append(lineSeparator).append("port=").append(getEntity().getDisplay().toString());//$NON-NLS-1$
Line 96:
Line 97:
ConsoleModel.makeConsoleConfigRequest(configBuilder.toString());
See the comment in ConsoleModel.
Line 98: }
Line 99:
Line 100: @Override
Line 101: protected void UpdateActionAvailability()
--
To view, visit http://gerrit.ovirt.org/11703
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib31e870deb7ecb3dac4cff25e49a3ebca4706a25
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
