Alon Bar-Lev has posted comments on this change.
Change subject: frontend: Non-plugin automatic invocation of console session
......................................................................
Patch Set 6: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java
Line 275: FormPanel formPanel = new FormPanel(new NamedFrame("_self"));
//$NON-NLS-1$
Line 276: formPanel.setMethod(FormPanel.METHOD_POST);
Line 277:
Line 278: FlowPanel innerPanel = new FlowPanel();
Line 279: innerPanel.add(buildTextArea("filename",
"console.vv"));//$NON-NLS-1$ $NON-NLS-2$
Still, filename, content type should be set when content is set, otherwise just
construct content here. These three are the same entity and should be specified
at single place, preferably at the data provider.
Line 280: innerPanel.add(buildTextArea("contenttype",
"x-virt-viewer"));//$NON-NLS-1$ $NON-NLS-2$
Line 281: innerPanel.add(buildTextArea("content",
configFileContent));//$NON-NLS-1$
Line 282:
Line 283: formPanel.setWidget(innerPanel);
--
To view, visit http://gerrit.ovirt.org/11703
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib31e870deb7ecb3dac4cff25e49a3ebca4706a25
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
