Michael Kublin has posted comments on this change.
Change subject: engine: Improve of RecoveryStoragePool
......................................................................
Patch Set 1: (2 inline comments)
Liron comments are irrelevant and wrong.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RecoveryStoragePoolCommand.java
Line 101:
getParameters().setStorageDomainId(getStorageDomainId().getValue());
Line 102: VdcReturnValueBase returnVal =
getBackend().runInternalAction(
Line 103:
VdcActionType.ReconstructMasterDomain, getParameters());
Line 104:
Line 105: isSucceeded = returnVal.getSucceeded();
Liron, start think your code is causing regression. Stop write workarounds. If
getsuccessed() is false - action is failed. If you change these you introduced
a bug.
I am not making a worka round in order to work with wrong code
Line 106: if (!isSucceeded) {
Line 107:
getStoragePoolIsoMapDAO().remove(domainPoolMap.getId());
Line 108: }
Line 109:
Line 114
Line 115
Line 116
Line 117
Line 118
No way. Maybe you will think, I successes and after that I am moving pool to
problematic? Really? Does it is sound logical not for me?
" i guess that the update to problematic status was done here before so
IrsProxyDate._updatingTimer_Elapsed will run for that pool and will update it's
status." - a new unicorn?
--
To view, visit http://gerrit.ovirt.org/11868
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0781e45b8ae76abe66fffcfad6654d27342a7c45
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
