Liron Aravot has posted comments on this change. Change subject: engine: Improve of RecoveryStoragePool ......................................................................
Patch Set 3: After taking to Michael f2f and after the 2 issues i've described in my first comment were resolved in the latest patchset - removing my -1. I'm still against returning the strong relation between reconstruct and recovery, we are one patch away from removing this inheritance between those classes (actually it can be done very easily now with almost none or no code changes at all). Removing -1 as there is no harm, i'd still prefer that this patch was merged without this execution change- other changes are fine by me (current situation is also fine in my opinion - it's debatable whether the connect operation should be done within the queue and same goes for the status update). -- To view, visit http://gerrit.ovirt.org/11868 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0781e45b8ae76abe66fffcfad6654d27342a7c45 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
