Liron Aravot has posted comments on this change. Change subject: engine: Improve of RecoveryStoragePool ......................................................................
Patch Set 1: I would prefer that you didn't submit this (2 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RecoveryStoragePoolCommand.java Line 101: getParameters().setStorageDomainId(getStorageDomainId().getValue()); Line 102: VdcReturnValueBase returnVal = getBackend().runInternalAction( Line 103: VdcActionType.ReconstructMasterDomain, getParameters()); Line 104: Line 105: isSucceeded = returnVal.getSucceeded(); this part will cause regression, not like reconstruct command - recovery is marked as succesful the moment that ReconstructMasterVDS is being send to vdsm and not if the whole reconstruct succeeded..now if ReconstructMasterVDS failed, this will be marked as failed as well..take look at bug https://bugzilla.redhat.com/show_bug.cgi?id=845838 Line 106: if (!isSucceeded) { Line 107: getStoragePoolIsoMapDAO().remove(domainPoolMap.getId()); Line 108: } Line 109: Line 114 Line 115 Line 116 Line 117 Line 118 this will cause regression, now if you initiate recovery when the pool is in maintenance, you will end with the master domain active and pool in maintenance - i guess that the update to problematic status was done here before so IrsProxyDate._updatingTimer_Elapsed will run for that pool and will update it's status. -- To view, visit http://gerrit.ovirt.org/11868 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0781e45b8ae76abe66fffcfad6654d27342a7c45 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
