Ofer Schreiber has posted comments on this change.
Change subject: packaging: allow interactive NFS exports cleanup with
engine-cleanup
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(2 inline comments)
Generally, patch looks good.
Please rebase and reverify, as a recent code change changed the "export
comment" behavior.
....................................................
File packaging/fedora/setup/engine-cleanup.py
Line 159: logging.debug("User chose to exit")
Line 160: return False
Line 161:
Line 162:
Line 163: def cleanNFSExports():
I'm missing some comments in this code, so it can be a bit more readablie
Line 164: if not options.unattended_clean:
Line 165: options.remove_nfs_exports =
askYesNo(MSG_CLEAN_NFS_EXPORTS_QUESTION)
Line 166: if not options.remove_nfs_exports:
Line 167: logging.debug("User chose to not clean NFS exports")
....................................................
File packaging/fedora/setup/nfsutils.py
Line 54: new_lines = []
Line 55: with open(exportFilePath, "r") as exportFile:
Line 56: lines = exportFile.readlines()
Line 57: for line in lines:
Line 58: if comment in line or "#rhev installer" in line:
A recent change modified this. it's now APP_NAME + "installer"
Line 59: logging.debug("removing %s from %s" % (line,
exportFilePath))
Line 60: path = line.split("\t")[0]
Line 61: removed_exports.append(path)
Line 62: continue
--
To view, visit http://gerrit.ovirt.org/11548
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0548ab358d0cbed32ceff3ceacefc57f1c068df4
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
