Alon Bar-Lev has posted comments on this change.
Change subject: packaging: allow interactive NFS exports cleanup with
engine-cleanup
......................................................................
Patch Set 4: (2 inline comments)
....................................................
File packaging/fedora/setup/nfsutils.py
Line 37: logging.debug("Backup old NFS exports configuration file")
Line 38: dateTimeSuffix = utils.getCurrentDateTime()
Line 39: backupFile = "%s.%s.%s" % (exportFilePath, "BACKUP",
dateTimeSuffix)
Line 40: logging.debug("Backing up %s into %s", exportFilePath, backupFile)
Line 41: utils.copyFile(exportFilePath, backupFile)
I am not sure you are right... but better to explicitly set proper permissions,
not sure about the selinux context though... does this file has one?
But this exactly why we need to use exports.d
Line 42:
Line 43:
Line 44: def cleanNfsExports(comment, exportFilePath=basedefs.FILE_ETC_EXPORTS):
Line 45: """
Line 40: logging.debug("Backing up %s into %s", exportFilePath, backupFile)
Line 41: utils.copyFile(exportFilePath, backupFile)
Line 42:
Line 43:
Line 44: def cleanNfsExports(comment, exportFilePath=basedefs.FILE_ETC_EXPORTS):
I think that it worth to split the logic, if we have /etc/exports.d support use
it, if not perform whatever magic that is required. We still need to be well
behaved on platforms that do support separate configuration directories.
Line 45: """
Line 46: Remove all the lines added by engine-setup marked by comment from
Line 47: exportFilePath.
Line 48: """
--
To view, visit http://gerrit.ovirt.org/11548
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0548ab358d0cbed32ceff3ceacefc57f1c068df4
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
