Frank Kobzik has posted comments on this change.
Change subject: core: Non-plugin automatic invocation of console session
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/console/ConsoleConfigServlet.java
Line 17: public class ConsoleConfigServlet extends IniServlet {
Line 18:
Line 19: private static final long serialVersionUID = 8496520437603585173L;
Line 20:
Line 21: private static final String CONFIG_FILE_HEADER = "[virt-viewer]";
Roy, we discussed this with Michal and we agreed that it is better solution
that relying on some (possibly partly filled) "template" config file
(substitution of variables etc.).
If you guys want changable header of the ini config, I would do it other way
(possibly special parameter, even though this isn't the best solution either.)
Line 22: private static final String HEADER_CONTENT_TYPE = "x-virt-viewer";
Line 23: private static final String HEADER_CONTENT_FILENAME = "console.vv";
Line 24:
Line 25: @Override
--
To view, visit http://gerrit.ovirt.org/11702
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I18b9d2efad15f5e9bb98a8176112b721c810205f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
