Liron Aravot has posted comments on this change. Change subject: engine: Making increase of storage pool master domain version atomic operation ......................................................................
Patch Set 1: (1 inline comment) Update to the column should be removed from Updatestorage_pool stored procedure. .................................................... File backend/manager/dbscripts/storages_sp.sql Line 40: AS $procedure$ Line 41: BEGIN Line 42: UPDATE storage_pool Line 43: SET description = v_description,name = v_name,storage_pool_type = v_storage_pool_type, Line 44: status = v_status,storage_pool_format_type = v_storage_pool_format_type,master_domain_version = v_master_domain_version, meaning : also from dao ofcourse and method params ofcourse. Line 45: spm_vds_id = v_spm_vds_id,compatibility_version = v_compatibility_version, Line 46: _update_date = LOCALTIMESTAMP,quota_enforcement_type=v_quota_enforcement_type Line 47: WHERE id = v_id; Line 48: END; $procedure$ -- To view, visit http://gerrit.ovirt.org/11500 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa2657ddfdbf2400f24341b07ab60743d6430481 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
