Liron Aravot has posted comments on this change.
Change subject: engine: Making increase of storage pool master domain version
atomic operation
......................................................................
Patch Set 1: (1 inline comment)
1.Update to the column should be removed from Updatestorage_pool stored
procedure.
2.From brief look seems that the set status in RecoveryStoragePool execute
method won't be updated in the db now.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java
Line 289: });
Line 290: } else {
Line 291: _isLastMaster = true;
Line 292: }
Line 293: updateStoragePoolMasterDomainVersionInDiffTransaction();
When getting here from RecoveryStoragePool, the pool status was updated as well
(see execute method in Recovery), now it won't be updated and the pool status
won't change or the setStatus in recovery is not relevant.
Line 294: }
Line 295: }
Line 296:
Line 297: protected AsyncTaskDAO getAsyncTaskDao() {
--
To view, visit http://gerrit.ovirt.org/11500
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa2657ddfdbf2400f24341b07ab60743d6430481
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
