Moti Asayag has posted comments on this change.

Change subject: engine: Added ability to affect sort order in search
......................................................................


Patch Set 7: (1 inline comment)

....................................................
File 
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/IConditionFieldAutoCompleter.java
Line 19:     IConditionValueAutoCompleter getFieldValueAutoCompleter(String 
fieldName);
Line 20: 
Line 21:     String buildFreeTextConditionSql(String tableName, String 
relations, String value, boolean caseSensitive);
Line 22: 
Line 23:     String buildConditionSql(String fieldName,
can you remove this change from this patch since it is refactor and not related 
to the rest of the patch.
Line 24:             String customizedValue,
Line 25:             String customizedRelation,
Line 26:             String tableName,
Line 27:             boolean caseSensitive);


--
To view, visit http://gerrit.ovirt.org/11469
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I80b65dacdccc208c8c7e0f2564f2660782d36d69
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to