Mike Kolesnik has posted comments on this change.
Change subject: engine: Added ability to affect sort order in search
......................................................................
Patch Set 4: (2 inline comments)
....................................................
File
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java
Line 33: protected final Map<String, List<ValueValidationFunction>>
mValidationDict =
Line 34: new HashMap<String, List<ValueValidationFunction>>();
Line 35: private final Map<String, Class<?>> mTypeDict = new
HashMap<String, Class<?>>();
Line 36: protected final Map<String, String> mColumnNameDict = new
HashMap<String, String>();
Line 37: protected final Map<String, String> mSortableFieldDict = new
HashMap<String, String>();
Hungarian notation isn't standard in the project as a whole.
I'm not sure that for the sake of uniformity with the other badly-named fields
you should also name your field this way.
However, it is entirely possible to add a preceding commit to rename the other
fields in this class to regular camelCase convention that we use in this
project, so you don't get "out of line" when adding this field.
Line 38: protected final List<String> mNotFreeTextSearchableFieldsList =
new ArrayList<String>();
Line 39:
Line 40: /**
Line 41: * Gets the LIKE clause syntax for non case-sensitive search
Line 136:
Line 137: }
Line 138:
Line 139: // FIXME Probably Not Hibernate Friendly
Line 140: public final String buildFreeTextConditionSql(String tableName,
For the future, please send formatting changes in a preceding commit so that
they don't interfere with spotting the actual changes..
Line 141: String relations,
Line 142: String value,
Line 143: boolean caseSensitive) {
Line 144: StringBuilder sb = new StringBuilder(" ( ");
--
To view, visit http://gerrit.ovirt.org/11469
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I80b65dacdccc208c8c7e0f2564f2660782d36d69
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
