Mike Kolesnik has posted comments on this change.
Change subject: engine: Added ability to affect sort order in search
......................................................................
Patch Set 5: (1 inline comment)
Basically approved, just one small comment
....................................................
File
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java
Line 120:
Line 121: public String getSortableDbField(String fieldName) {
Line 122: if (sortableFieldDict.containsKey(fieldName)) {
Line 123: return sortableFieldDict.get(fieldName);
Line 124: }
By convention we don't put newline before else statement
Line 125: else {
Line 126: return getDbFieldName(fieldName);
Line 127: }
Line 128: }
--
To view, visit http://gerrit.ovirt.org/11469
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I80b65dacdccc208c8c7e0f2564f2660782d36d69
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
