Einav Cohen has posted comments on this change.
Change subject: userportal: set grid's items only on change
......................................................................
Patch Set 2:
Gilad: several questions:
1) vm_pool's defaultStartTime/defaultEndTime issue:
- this patch should not be submitted without a fix to this issue, since
without this fix - the "shouldBeRefreshed" method in IUserPortalListModel will
always return "true", which will result in re-rendering of the view in each
refresh, so no rendering optimization will actually occur. Is that correct?
- you said: "check in vm_pools:eqauls, it's always different". Did you mean
that the 'equals' method is wrong and should be fixed, or that the actual
values for the defaultStartTime/defaultEndTime vm_pool fields are different for
each retrieval from the backend?
2) [assuming 1 is fixed] From the "shouldBeRefreshed" method:
if (!currentVm.getStaticData().equals(newVm.getStaticData()) ||
!currentVm.getStatus().equals(newVm.getStatus())) { ...
Looking at the "equals" method of the VmStatic business entity, it seems that
not all fields are being checked there (e.g. "NumOfMonitors" is not being
checked).
Which means that there is a chance that although the VM has been updated, the
"equals" method for VmStatic will return "true", which means that
shouldBeRefreshed will return "false", which means that the grid won't be
re-rendered, which is OK, as long as we are not displaying the relevant field
(e.g. NumOfMonitors) in the grid.
Question is: What will happen when the user will select that row and be
displayed with the "General" sub tab (which contains the "numOfMonitors"
information) and/or when the user attempts to Edit the VM? Will the user see
the updated VM, or the "old" one?
--
To view, visit http://gerrit.ovirt.org/10579
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8bd8c3cb312f89125e8c0a0182f49fe74f9f02d1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
