Vojtech Szocs has posted comments on this change. Change subject: userportal: set grid's items only on change ......................................................................
Patch Set 3: Regarding following issue: > For editing view (dialogs) - need to make sure that all the data within the > dialog (once opening it) is up-to-date This can be fixed by following similar approach as in http://gerrit.ovirt.org/#/c/10509 * do not try to fix the problem on UiCommon level, e.g. UserPortalListModel.setItems method * instead, fix the problem on UI level, e.g. override updateDataProvider method in UserPortalListProvider * in UserPortalListProvider.updateDataProvider method, determine what needs to be updated (new items to add, existing items to update, old items to remove) * instead of refreshing *all* rows when *something* needs to be updated, update only relevant rows - do AsyncDataProvider.updateRowData(offset,itemSubset) instead of AsyncDataProvider.updateRowData(0,allItems) * this also fixes the current limitation when *all* rows are updated when *something* needs to be updated, e.g. UserPortalListModel.setItems(allItems) even when single item changes -- To view, visit http://gerrit.ovirt.org/10579 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8bd8c3cb312f89125e8c0a0182f49fe74f9f02d1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
