Alon Bar-Lev has posted comments on this change. Change subject: webadmin: Use ConfigCommon version in AsyncDataProvider ......................................................................
Patch Set 1: Hello, The effort is to remove the need to split and duplicate configuration details between ConfigValues, ConfigurationValues, engine-config.properties and the various database SQL scripts into a single artifact, use code generation in order to avoid duplication and eliminate the storage of default values in database. The 'general' magic token in this case will be also generated. At first patch it was moved from Config.DefaultConfigurationVersion into ConfigCommon.defaultConfigurationVersion, so that the ConfigCommon can be completely code generated. Then Gilad rightfully alerted that it is an opportunity to decouple the front-end by fetching it, which is reasonable, as any duplication we remove we are closer to a better code. I hope this answers your question. Alon BTW: the same code generation method should also address the duplication of messages. -- To view, visit http://gerrit.ovirt.org/11174 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c9213aee9182d3bb27fbba04f7163b502438a3e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
