Kanagaraj M has posted comments on this change.
Change subject: webadmin: Add cluster policy to edit cluster
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGeneralModel.java
Line 140: {
Line 141: super.setEntity(value);
Line 142: }
Line 143:
Line 144: public ClusterGeneralModel(ClusterListModel clusterListModel)
Alternatively you can pass the EditCommand itself here and assign it to
EditPolicyCommand. So you avoid creating another EditPolicyCommand which
internally invokes the actual EditCommand.
I can see you are focusing the Policy tab if Edit Policy is clicked. you can
achieve that by using
@Override
public void ExecuteCommand(UICommand uiCommand, Object... parameters) {
}
in ClusterListModel.
So in ClusterGeneralView you could do the following
editPolicyButton.addClickHandler(new ClickHandler() {
@Override
public void onClick(ClickEvent event) {
getDetailModel().getEditPolicyCommand().Execute(Boolean.TRUE);
}
});
Line 145: {
Line 146: this.clusterListModel = clusterListModel;
Line 147:
setTitle(ConstantsManager.getInstance().getConstants().generalTitle());
Line 148: setHashName("general"); //$NON-NLS-1$
--
To view, visit http://gerrit.ovirt.org/10573
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I195d9ec1c7901a31e6e656221964d82bc90c9695
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <oma...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
