Tal Nisan has posted comments on this change.
Change subject: core: Improve logs in DbUserCacheManager
......................................................................
Patch Set 1: (2 inline comments)
Minor comments, other than that +2
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java
Line 87: * LDAP user
Line 88: * @param updatedUsers
Line 89: * list of changed users.
Line 90: */
Line 91: private void updateDBUserFromADUser(DbUser dbUser, LdapUser
adUser, HashSet<Guid> updatedUsers) {
Not a part of the logs I know, but can you change the param name from adUser to
ldapUser? it's a part of an cross platform entity name change from a couple of
week ago
Line 92: boolean succeded = false;
Line 93: // AdUser adUser =
Line 94: //
LdapFactory.Instance.GetAdUserByUserIdAndDomain(dbUser.user_id,
Line 95: // dbUser.domain);
Line 91: private void updateDBUserFromADUser(DbUser dbUser, LdapUser
adUser, HashSet<Guid> updatedUsers) {
Line 92: boolean succeded = false;
Line 93: // AdUser adUser =
Line 94: //
LdapFactory.Instance.GetAdUserByUserIdAndDomain(dbUser.user_id,
Line 95: // dbUser.domain);
The commented part can be removed, it will not work anymore anyway
Line 96: if ((adUser == null) || (adUser.getUserId().equals(Guid.Empty))
Line 97: || (!adUser.getUserId().equals(dbUser.getuser_id()))) {
Line 98: if (dbUser.getstatus() != 0) {
Line 99: log.warnFormat("User {0} not found in directory
server, its status switched to InActive",
--
To view, visit http://gerrit.ovirt.org/10825
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I46c0cffd1280f2781000b608496f1e4104faca8a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
