Kanagaraj M has posted comments on this change. Change subject: engine: Get gluster hooks query ......................................................................
Patch Set 6: (3 inline comments) .................................................... File backend/manager/dbscripts/gluster_hooks_sp.sql Line 75: RETURNS VOID Line 76: AS $procedure$ Line 77: BEGIN Line 78: DELETE FROM gluster_hooks Line 79: WHERE id in (select ID from fnSplitterUuid(v_hook_ids)); this should be "select * from fnSplitterUuid(v_hook_ids)" Line 80: END; $procedure$ Line 81: LANGUAGE plpgsql; Line 82: Line 83: Line 104: UPDATE gluster_hooks Line 105: SET Line 106: hook_status = v_status, Line 107: _update_date = LOCALTIMESTAMP Line 108: WHERE cluster_id = v_cluster_id AND hook_name = v_hook_name; what if there are two hooks with same name, one in PRE and the other in POST? Line 109: END; $procedure$ Line 110: LANGUAGE plpgsql; Line 111: Line 112: .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterHookStage.java Line 13: Line 14: /** Line 15: * Hook execution level - post Line 16: */ Line 17: POST, please update the level to stage. Line 18: -- To view, visit http://gerrit.ovirt.org/10650 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8b2d261ead720fccea6884acbc806ec79e52b36 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Selvasundaram <sesub...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
