Selvasundaram has posted comments on this change.

Change subject: engine: Get gluster hooks query
......................................................................


Patch Set 5: (4 inline comments)

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterHookLevel.java
Line 4:  * Enum of Gluster Hook Level
Line 5:  *
Line 6:  * @see GlusterHookEntity
Line 7:  */
Line 8: public enum GlusterHookLevel {
Done
Line 9:     /**
Line 10:      * Hook execution level - pre
Line 11:      */
Line 12:     PRE,


....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 786: VALIDATION.GLUSTER.VOLUME.BRICK.SERVER_ID.NOT_NULL=Brick Server ID is 
required.
Line 787: VALIDATION.GLUSTER.VOLUME.BRICK.BRICK_DIR.NOT_NULL=Brick Directory is 
required.
Line 788: VALIDATION.GLUSTER.HOOK.ID.NOT_NULL=Gluster Hook ID is required.
Line 789: VALIDATION.GLUSTER.HOOK.NAME.NOT_NULL=Gluster Hook name is required.
Line 790: VALIDATION.GLUSTER.HOOK.GLUSTERCOMMAND.NOT_NULL=Gluster command is 
required.
Done
Line 791: ACTION_TYPE_FAILED_CLUSTER_IS_NOT_VALID=Cannot ${action} ${type}. 
Cluster ID is not valid.
Line 792: ACTION_TYPE_FAILED_CLUSTER_DOES_NOT_SUPPORT_GLUSTER=Cannot ${action} 
${type}. Cluster does not support Gluster service.
Line 793: ACTION_TYPE_FAILED_GLUSTER_VOLUME_NAME_ALREADY_EXISTS=Cannot 
${action} ${type}. Volume name ${volumeName} already exists.
Line 794: ACTION_TYPE_FAILED_GLUSTER_VOLUME_INVALID=Cannot ${action} ${type}. 
Gluster Volume is not valid.


Line 833: VDS_GROUP_ENABLING_BOTH_VIRT_AND_GLUSTER_SERVICES_NOT_ALLOWED=Cannot 
${action} ${type}. Enabling both Virt and Gluster services is not allowed.
Line 834: ENGINE_IS_RUNNING_IN_MAINTENANCE_MODE=Engine is running in 
Maintenance mode and is not accepting commands.
Line 835: ENGINE_IS_RUNNING_IN_PREPARE_MODE=This action is not allowed when 
Engine is preparing for maintenance.
Line 836: ACTION_TYPE_FAILED_SERVER_NAME_REQUIRED=Cannot ${action} ${type}. 
Server Name required.
Line 837: SERVER_ALREADY_EXISTS_IN_ANOTHER_CLUSTER=One or more servers are 
already part of an existing cluster.
Is it required?
Ok I will revert back.
Line 838: # Exteral Events Errors Messages
Line 839: VAR__TYPE__EXTERNAL_EVENT=$type Exteral Event
Line 840: ACTION_TYPE_FAILED_EXTERNAL_EVENT_ILLEGAL_ORIGIN=Cannot ${action} 
${type}. Illegal Origin for External Event : oVirt
Line 841: ACTION_TYPE_FAILED_EXTERNAL_EVENT_NOT_FOUND=Cannot ${action} 
${type}.External Event does not exist.


....................................................
File 
backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
Line 326: GlusterAddHostFailed=Gluster Server Add Failed
Line 327: GlusterHostRemoveFailed=Gluster Server Remove Failed
Line 328: GlusterPeerListFailed=Gluster Peer List Failed
Line 329: GlusterVolumeStatusFailed=Could not fetch advanced volume details
Line 330: GlusterVolumeProfileInfoFailed=Gluster Volume Profile Info Failed
Done
Line 331: CANT_RECONSTRUCT_WHEN_A_DOMAIN_IN_POOL_IS_LOCKED=Can't reconstruct 
the Master Domain when the Data Center contains Domains in Locked 
state.\nPlease wait until the operation for these Domains ends before trying to 
reconstruct the Master Domain again.
Line 332: NO_IMPLEMENTATION=Not implemented
Line 333: FailedToPlugDisk=Failed to hot-plug disk
Line 334: FailedToUnPlugDisk=Failed to hot-unplug disk


--
To view, visit http://gerrit.ovirt.org/10650
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8b2d261ead720fccea6884acbc806ec79e52b36
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to