Maor Lipchuk has posted comments on this change.
Change subject: core: AuditLogDirector tests and some cleanups
......................................................................
Patch Set 6: Looks good to me, but someone else must approve
(2 inline comments)
Looks good, see minor comments
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
Line 27: private static final Map<AuditLogType, String> mMessages = new
EnumMap<AuditLogType, String>(AuditLogType.class);
Line 28: private static final Map<AuditLogType, AuditLogSeverity>
mSeverities =
Line 29: new EnumMap<AuditLogType,
AuditLogSeverity>(AuditLogType.class);
Line 30: private static final Pattern pattern =
Pattern.compile("\\$\\{\\w*\\}"); // match ${<alphanumeric>...}
Line 31: static final String UNKNOWN_VARIABLE_VALUE = "<UNKNOWN>";
probably protected is more fitting here?
Line 32:
Line 33: static {
Line 34: initMessages();
Line 35: initSeverities();
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirectorTest.java
Line 3: /**
Line 4: * TODO:
Line 5: * Commented out test class in order to cancel dependency on PowerMock
Line 6: * This should be revisited.
Line 7: */
Is this comment still relevant now?
Line 8:
Line 9: //import static org.mockito.Mockito.when;
Line 10: //
Line 11: import java.util.Collections;
--
To view, visit http://gerrit.ovirt.org/10497
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cb777a39dbe19510d8a0466e6dff80da1b234ba
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
