Vered Volansky has posted comments on this change.
Change subject: core: AuditLogDirector tests and some cleanups
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
Line 774:
Line 775: if (auditLogable == null || auditLogable.getLegal()) {
Line 776: String message = null;
Line 777: String resolvedMessage = null;
Line 778: AuditLogSeverity severity;
1.severity in not initialized here anymore.
2.No use of local variable severity after assignment, should be discarded.
Line 779: if ((severity = mSeverities.get(logType)) == null) {
Line 780: severity = AuditLogSeverity.NORMAL;
Line 781: log.infoFormat("No severity for {0} type", logType);
Line 782: }
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirectorTest.java
Line 90: @Test
Line 91: public void testResolveKnownVariable() {
Line 92: final String message = "This is my ${Variable}";
Line 93: final String expectedResolved = "This is my value";
Line 94: Map<String, String> values = new HashMap<String, String>();
singltonMap
Line 95: values.put("variable", "value");
Line 96: String resolvedMessage =
AuditLogDirector.resolveMessage(message, values);
Line 97: Assert.assertEquals(expectedResolved, resolvedMessage);
Line 98: }
--
To view, visit http://gerrit.ovirt.org/10497
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cb777a39dbe19510d8a0466e6dff80da1b234ba
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
