Vered Volansky has posted comments on this change.
Change subject: core: AuditLogDirector tests and some cleanups
......................................................................
Patch Set 6: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
Line 957: String stringValue = value != null ? value.toString() :
null;
Line 958: if
(!returnValue.containsKey(propertyInfo.getName().toLowerCase())) {
Line 959: returnValue.put(propertyInfo.getName().toLowerCase(),
stringValue);
Line 960: } else {
Line 961: log.errorFormat("Try to add duplicate audit log
values with same name. Type: {0}. Value: {1}",
/same/the same, not that important, I think.
Line 962: logable.getAuditLogTypeValue(),
propertyInfo.getName().toLowerCase());
Line 963: }
Line 964: }
Line 965: List<String> attributes =
AuditLogHelper.getCustomLogFields(logable.getClass(), true);
--
To view, visit http://gerrit.ovirt.org/10497
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cb777a39dbe19510d8a0466e6dff80da1b234ba
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
