Shireesh Anjal has posted comments on this change. Change subject: engine: Fix SHD service not displaying issue (#885592) ......................................................................
Patch Set 3: (3 inline comments) .................................................... File backend/manager/dbscripts/gluster_volumes_sp.sql Line 109: BEGIN Line 110: RETURN QUERY SELECT * Line 111: FROM gluster_volumes Line 112: WHERE cluster_id = v_cluster_id AND status = v_status Line 113: AND vol_type IN (v_vol_types) Does this really work when multiple comma-separated values are passed? I doubt. I believe this should look like: AND vol_type IN (select ID from fnSplitter(v_vol_types)) Line 114: AND id IN (SELECT volume_id FROM gluster_volume_options Line 115: WHERE option_key=v_option_key AND option_val=v_option_val); Line 116: END; $procedure$ Line 117: LANGUAGE plpgsql; .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDao.java Line 31: String optionValue); Line 32: Line 33: public List<GlusterVolumeEntity> getVolumesByStatusTypesAndOption(Guid clusterId, Line 34: GlusterStatus status, Line 35: List<String> volumeTypes, This should be List<GlusterVolumeType> Line 36: String optionKey, Line 37: String optionValue); Line 38: Line 39: public List<GlusterVolumeEntity> getVolumesByStatusAndTypes(Guid clusterId, Line 37: String optionValue); Line 38: Line 39: public List<GlusterVolumeEntity> getVolumesByStatusAndTypes(Guid clusterId, Line 40: GlusterStatus status, Line 41: List<String> volumeTypes); Same here. Line 42: Line 43: @Override Line 44: public List<GlusterVolumeEntity> getAllWithQuery(String query); Line 45: -- To view, visit http://gerrit.ovirt.org/10336 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id11725f44ab3fdd36f76fe569d7610a411518ee1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dhandapani Gopal <dgo...@redhat.com> Gerrit-Reviewer: Dhandapani Gopal <dgo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
