Liron Aravot has posted comments on this change.
Change subject: core : BLL changes for Multi-Tier fencing
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
Line 294: }
Line 295: }
Line 296: }
Line 297:
Line 298: private void runThread(CountDownLatch latch, VDSReturnValue
value, FencingExecutor executor, FenceAgentOrder order, boolean succeeded) {
I was let know that my comments here were unclear and confused, I agree so i'll
sum it up in one comment -
1. no need to pass the suceeded member as it's not used within the runThread
method.
2. If you do want to change the class member, no need to pass it.
3. If few threads attempt to change it, concurrency issues should be handled.
4. bad edit that led to bad wording in first comment, my meaning was that you
could use the wrapper 'RefObject' with Boolean to pass to the run method and
change the value within, not changing to Boolean alone of course won't do any
good as it's immutable.
sorry for the bad wording, my bad.
Line 299: value = executor.Fence(order);
Line 300: if (value.getSucceeded()) {
Line 301: try {
Line 302: executor = new FencingExecutor(getVds(),
FenceActionType.Status);
--
To view, visit http://gerrit.ovirt.org/10260
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82f243593f2b361ca75d97e06f9aede246d4a1b1
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
