Liron Aravot has posted comments on this change.
Change subject: core : BLL changes for Multi-Tier fencing
......................................................................
Patch Set 8: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
Line 258: });
Line 259: ThreadPoolUtil.execute(new Runnable() {
Line 260: @Override
Line 261: public void run() {
Line 262: runThread(latch, secondaryReturnValue,
secondaryExecutor, FenceAgentOrder.Secondary, secondarySucceeded);
As I wrote, they are class members and that's an anonymous class..all need to
be done in order to get it to work is to not pass them to the method and it'll
work fine.
general unrelated note: in ovirt people also use RefObject for multiple return
value, in that case we don't even need it as it's an anonymous class.
Line 263: }
Line 264: });
Line 265: try {
Line 266: latch.await();
--
To view, visit http://gerrit.ovirt.org/10260
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82f243593f2b361ca75d97e06f9aede246d4a1b1
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
