Vojtech Szocs has posted comments on this change. Change subject: webadmin: adding loginUserId and loginUserName provider functions ......................................................................
Patch Set 3: > See comment about changing the type of the userID. Okay with me, just make > sure it works well. In previous patch set, CurrentUser get/setUserId was using Guid, but in practice, PluginEventHandler called "getUserId().toString()" to pass user ID as string to plugins. The same would be true for PluginManager's loginUserName API function. In other words, there's no need to have user ID represented as Guid in CurrentUser for now. Alternatively, you can modify CurrentUser get/setUserId to use Guid, and also provide method like getUserIdAsString that would call "getUserId().toString()". What do you think about this? -- To view, visit http://gerrit.ovirt.org/9998 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I932e329668d7fc8d0a3608d2984d2645a98fe053 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
