Oved Ourfali has posted comments on this change. Change subject: webadmin: adding loginUserId and loginUserName provider functions ......................................................................
Patch Set 3: Looks good to me, approved (1 inline comment) See comment about changing the type of the userID. Okay with me, just make sure it works well. Thank you, Oved .................................................... File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/auth/CurrentUser.java Line 23: private final EventBus eventBus; Line 24: Line 25: private boolean loggedIn = false; Line 26: private String userName; Line 27: private String userId; did you make sure this change doesn't effect anything? Line 28: Line 29: // Indicates that the user should be logged in automatically Line 30: private boolean autoLogin = false; Line 31: -- To view, visit http://gerrit.ovirt.org/9998 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I932e329668d7fc8d0a3608d2984d2645a98fe053 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
