Allon Mureinik has posted comments on this change.
Change subject: core:StorageHelper cleanup, code clean
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
Line 34: public boolean runForSingleConnectionInHost(storage_domains
storageDomain, Guid storagePoolId, int type) {
Line 35: storage_pool pool =
DbFacade.getInstance().getStoragePoolDao().get(storagePoolId);
Line 36: if (pool.getspm_vds_id() != null) {
Line 37: return runConnectionStorageToDomain(storageDomain,
pool.getspm_vds_id().getValue(), type);
Line 38: } else {
The return terminates the if - you should remove the else
Line 39: log.errorFormat("Pool {0} does not have spm vds id to
connect storage to domain.", pool.getname());
Line 40: return false;
Line 41: }
Line 42: }
--
To view, visit http://gerrit.ovirt.org/10140
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica461c6d592932a061472bf87e47e6bfa0687e3d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
