Yaniv Bronhaim has posted comments on this change.
Change subject: Adding system information to getCapabilities from host
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File backend/manager/dbscripts/upgrade/03_01_1520_add_vds_bios_info.sql
Line 2: select fn_db_add_column('vds_dynamic', 'host_product_name',
'VARCHAR(40)');
Line 3: select fn_db_add_column('vds_dynamic', 'host_version', 'VARCHAR(40)');
Line 4: select fn_db_add_column('vds_dynamic', 'host_serial_number',
'VARCHAR(40)');
Line 5: select fn_db_add_column('vds_dynamic', 'host_uuid', 'VARCHAR(40)');
Line 6: select fn_db_add_column('vds_dynamic', 'host_family', 'VARCHAR(40)');
I just figure that most of the short string variables in vds_dynamic are set to
varchar(40) so I took it as reference and used it too. What do you suggest? 40
looks long enough for those values, but there are all surprises.
--
To view, visit http://gerrit.ovirt.org/9337
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I142198d2059cf109be3859f255621e6ceca8582b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
