Alexander Wels has posted comments on this change.
Change subject: webadmin: Added the ability to define a 'no items' message.
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
(12 inline comments)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
Line 2438:
Line 2439: //No items to display messages.
Line 2440: @DefaultStringValue("No data centers to display")
Line 2441: String noDataCentersToDisplay();
Line 2442:
Done
Line 2443: @DefaultStringValue("No disks to display")
Line 2444: String noDisksToDisplay();
Line 2445:
Line 2446: @DefaultStringValue("No clusters to display")
Line 2441: String noDataCentersToDisplay();
Line 2442:
Line 2443: @DefaultStringValue("No disks to display")
Line 2444: String noDisksToDisplay();
Line 2445:
Done
Line 2446: @DefaultStringValue("No clusters to display")
Line 2447: String noClustersToDisplay();
Line 2448:
Line 2449: @DefaultStringValue("No virtual machines to display")
Line 2443: @DefaultStringValue("No disks to display")
Line 2444: String noDisksToDisplay();
Line 2445:
Line 2446: @DefaultStringValue("No clusters to display")
Line 2447: String noClustersToDisplay();
Done
Line 2448:
Line 2449: @DefaultStringValue("No virtual machines to display")
Line 2450: String noVMsToDisplay();
Line 2451:
Line 2447: String noClustersToDisplay();
Line 2448:
Line 2449: @DefaultStringValue("No virtual machines to display")
Line 2450: String noVMsToDisplay();
Line 2451:
Done
Line 2452: @DefaultStringValue("No pools to display")
Line 2453: String noPoolsToDisplay();
Line 2454:
Line 2455: @DefaultStringValue("No templates to display")
Line 2450: String noVMsToDisplay();
Line 2451:
Line 2452: @DefaultStringValue("No pools to display")
Line 2453: String noPoolsToDisplay();
Line 2454:
Done
Line 2455: @DefaultStringValue("No templates to display")
Line 2456: String noTemplatesToDisplay();
Line 2457:
Line 2458: @DefaultStringValue("No networks to display")
Line 2453: String noPoolsToDisplay();
Line 2454:
Line 2455: @DefaultStringValue("No templates to display")
Line 2456: String noTemplatesToDisplay();
Line 2457:
Done
Line 2458: @DefaultStringValue("No networks to display")
Line 2459: String noNetworksToDisplay();
Line 2460:
Line 2461: @DefaultStringValue("No volumes to display")
Line 2456: String noTemplatesToDisplay();
Line 2457:
Line 2458: @DefaultStringValue("No networks to display")
Line 2459: String noNetworksToDisplay();
Line 2460:
Done
Line 2461: @DefaultStringValue("No volumes to display")
Line 2462: String noVolumesToDisplay();
Line 2463:
Line 2464: @DefaultStringValue("No users to display")
Line 2459: String noNetworksToDisplay();
Line 2460:
Line 2461: @DefaultStringValue("No volumes to display")
Line 2462: String noVolumesToDisplay();
Line 2463:
Done
Line 2464: @DefaultStringValue("No users to display")
Line 2465: String noUsersToDisplay();
Line 2466:
Line 2467: @DefaultStringValue("No events to display")
Line 2462: String noVolumesToDisplay();
Line 2463:
Line 2464: @DefaultStringValue("No users to display")
Line 2465: String noUsersToDisplay();
Line 2466:
Done
Line 2467: @DefaultStringValue("No events to display")
Line 2468: String noEventsToDisplay();
Line 2469:
Line 2470: @DefaultStringValue("No storage to display")
Line 2465: String noUsersToDisplay();
Line 2466:
Line 2467: @DefaultStringValue("No events to display")
Line 2468: String noEventsToDisplay();
Line 2469:
Done
Line 2470: @DefaultStringValue("No storage to display")
Line 2471: String noStorageToDisplay();
Line 2472:
Line 2473: @DefaultStringValue("No hosts to display")
Line 2468: String noEventsToDisplay();
Line 2469:
Line 2470: @DefaultStringValue("No storage to display")
Line 2471: String noStorageToDisplay();
Line 2472:
Done
Line 2473: @DefaultStringValue("No hosts to display")
Line 2474: String noHostsToDisplay();
Line 2470: @DefaultStringValue("No storage to display")
Line 2471: String noStorageToDisplay();
Line 2472:
Line 2473: @DefaultStringValue("No hosts to display")
Line 2474: String noHostsToDisplay();
Done
--
To view, visit http://gerrit.ovirt.org/9830
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If808e7c1bc92877d3f59b766985900a2c8ffd216
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
