Mike Kolesnik has posted comments on this change.
Change subject: core: add NetworkLinking to AddVmInterfaceCommand
......................................................................
Patch Set 9: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmInterfaceCommand.java
Line 181:
Line 182: if (!unlinkingSupported) {
Line 183: if (!getParameters().getInterface().isLinked()) {
Line 184:
addCanDoActionMessage(VdcBllMessages.UNLINKING_IS_NOT_SUPPORTED);
Line 185:
getReturnValue().getCanDoActionMessages().add(String.format("$version %1$s",
You can use addCanDoActionMessage(String) here
Line 186: getVm().getvds_group_compatibility_version().
Line 187: getValue()));
Line 188: return false;
Line 189: }
Line 189: }
Line 190:
Line 191: if (getParameters().getInterface().getNetworkName() ==
null) {
Line 192:
addCanDoActionMessage(VdcBllMessages.NULL_NETWORK_IS_NOT_SUPPORTED);
Line 193:
getReturnValue().getCanDoActionMessages().add(String.format("$version %1$s",
You can use addCanDoActionMessage(String) here
Line 194: getVm().getvds_group_compatibility_version().
Line 195: getValue()));
Line 196: return false;
Line 197: }
--
To view, visit http://gerrit.ovirt.org/9447
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I295dfb0af1bb7c6b2878f70344afd487aa2efbe1
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
