Mike Kolesnik has posted comments on this change.
Change subject: core: add NetworkLinking to AddVmInterfaceCommand
......................................................................
Patch Set 4: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmInterfaceCommand.java
Line 121: }
Line 122:
Line 123: @Override
Line 124: protected boolean canDoAction() {
Line 125:
Done
Line 126: VmStatic vm = getVm().getStaticData();
Line 127: if (vm == null) {
Line 128:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_VM_NOT_EXIST);
Line 129: return false;
Line 163: }
Line 164:
Line 165: boolean unlinkingSupported =
Line 166: Config.<Boolean>
GetValue(ConfigValues.NetworkLinkingSupported,
Line 167: getVm().getVdsGroupCompatibilityVersion().
Done
Line 168: getValue());
Line 169:
Line 170: if (!unlinkingSupported) {
Line 171: if (!getParameters().getInterface().isLinked()) {
Line 167: getVm().getVdsGroupCompatibilityVersion().
Line 168: getValue());
Line 169:
Line 170: if (!unlinkingSupported) {
Line 171: if (!getParameters().getInterface().isLinked()) {
Done
Line 172:
addCanDoActionMessage(VdcBllMessages.UNLINKING_IS_NOT_SUPPORTED);
Line 173: addCanDoActionMessage(String.format("$clusterVersion
%1$s",
Line 174: getVm().getVdsGroupCompatibilityVersion().
Line 175: getValue()));
Line 184: return false;
Line 185: }
Line 186: }
Line 187:
Line 188: if (getParameters().getInterface().getNetworkName() != null) {
Done
Line 189: // check that the exists in current cluster
Line 190: List<Network> networks =
DbFacade.getInstance().getNetworkDao().getAllForCluster(vm.getvds_group_id());
Line 191:
Line 192: Network interfaceNetwork =
LinqUtils.firstOrNull(networks, new Predicate<Network>() {
--
To view, visit http://gerrit.ovirt.org/9798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f804e0d3117eed22814a8397d0fee12dd9e1347
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
