Allon Mureinik has posted comments on this change. Change subject: engine: Query getdisksvmguid caused postmaster processes to consume constantly 100%cpu. ......................................................................
Patch Set 1: (1 inline comment) mkublin - also note yzaslavs and my comments on the commit message. Please fix it when you rebase and merge. .................................................... Commit Message Line 6: Line 7: engine: Query getdisksvmguid caused postmaster processes to consume constantly 100%cpu. Line 8: Line 9: The following bug is occurred because of a following query is running from GetVmStatsVDSCommand for Line 10: every running vm in the system . The run is cyclic and runs in infinitive loop. The following bug occurrs because of the following query being run from GetVmStatsVDSCommand every running VM in the system. Line 11: I don't see reason for that query, update of dynamic data ofor disc is done under lock, in worst case Line 12: the dynamic data will be updated with wrong values, in next run which occurring every 4 seconds, the Line 13: disk will be updated with correct values. Line 14: I think we can live with wrong values for 4 seconds in case of race -- To view, visit http://gerrit.ovirt.org/9468 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ef4a24908a75ab4fc1f02eed7c97a7125a5db41 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
